Add runtime_env isolation for multi-cluster coordination paths#58
Merged
Conversation
TejasNaikk
force-pushed
the
feature/runtime-env-isolation
branch
from
0160edd to
096a5cf
Compare
GeorgeZhai
reviewed
Jan 8, 2026
| log.info("Initializing cluster-agnostic MetadataStore connection to etcd"); | ||
| try { | ||
| // Configure EtcdPathResolver with runtime environment for path isolation | ||
| EtcdPathResolver.getInstance().setRuntimeEnv(config.getRuntimeEnv()); |
Collaborator
There was a problem hiding this comment.
i think normally config yml is seen as build time config (static), run time is normally set by environment variables.
maybe we can make the value in application.yml as a default value to be overridden by a environment variables?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controllers in different environments (staging, production) now use isolated etcd paths for multi-cluster coordination, preventing cross-environment interference.
Changes:
runtime_envconfig toClusterControllerConfig(default: staging)/multi-cluster/<env>/controllers/...Example:
Staging controller →
/multi-cluster/staging/controllers/controller-1/heartbeatProduction controller →
/multi-cluster/production/controllers/controller-1/heartbeatTest Plan
Unit Tests
Local Tests:
After starting 3 controllers simultaneously with 3 os clusters