Skip to content

Don't convert to Path again if it's already a Path in convert_traces_to_training_data() #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armand0e merged 2 commits into from
Jun 18, 2026
Merged

Don't convert to Path again if it's already a Path in convert_traces_to_training_data() #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96bd86f
Don't convert to Path again if it's already a Path
lhoestq Jun 17, 2026
b18cb66
wrong order
lhoestq Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/teich/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3628,7 +3628,7 @@ def _convert_jsonl_file_to_training_rows(jsonl_file: Path) -> list[dict[str, Any


def convert_traces_to_training_data(traces_dir: Path | str) -> list[dict[str, Any]]:
source = Path(traces_dir)
source = Path(traces_dir) if not isinstance(traces_dir, Path) else traces_dir
trace_files = _jsonl_files(source)
rows: list[dict[str, Any]] = []
for path in trace_files:
Expand Down
Loading