feat: Add RPC certificate pinning support - #756
Open
p70436464-prog wants to merge 2 commits into
Open
p70436464-prog wants to merge 2 commits into
p70436464-prog wants to merge 2 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #421
Description
This PR introduces TLS certificate pinning for the RPC client as defense-in-depth against DNS hijacking or compromised CAs. It adds an optional
rpcCertificateFingerprintfield to the configuration, which is especially useful for teams pointingsorokeepagainst private or elevated-trust mainnet-adjacent RPC endpoints.Changes
rpcCertificateFingerprintoption to~/.sorokeep/config.yaml(src/utils/config.ts).StellarRpcClientto inject anundici.Agentcontaining a customcheckServerIdentityTLS verification step into thefetchdispatcher when the fingerprint is configured.docs/config-reference.mdexplaining how users can get their fingerprint viaopenssl.tests/rpc/client.test.tsfor the custom fetch integration and constructor config parsing.By default (with no pinned fingerprint), the connection behavior and standard TLS validation remain unchanged.