Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maryyy_ux_Weather-app #438

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Maryyy_ux_Weather-app #438

wants to merge 6 commits into from

Conversation

Maryyy-ux
Copy link

HIPPIEKICK
HIPPIEKICK requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have another look at the requirement and make sure you display the data in the expected format (e.g. weekdays). Something's buggy with the temperatures as well: temp, min and max are the same numbers.

Also - to make it look less buggy when starting off, give the city a starting value when declaring it so that you can fetch weather from somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HIPPIEKICK HIPPIEKICK HIPPIEKICK requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maryyy-ux @HIPPIEKICK