Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project-portfolio #403

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Project-portfolio #403

wants to merge 11 commits into from

Conversation

Heleneabrahamsson
Copy link

HIPPIEKICK
HIPPIEKICK requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove your node modules so that we can do a proper review of your code, as well as remove any dark/light mode styling you have as I think that's what's causing your portfolio to look broken. After that I can do a more thorough review.

Skärmavbild 2024-12-09 kl 11 37 06

HIPPIEKICK
HIPPIEKICK requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're off to a good start Helene, but you still need to work on the design a bit. Make sure it looks good on all screen widths (and get rid of the side scroll) and take another look at the design. Be as thorough as you can and go through spacings and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HIPPIEKICK HIPPIEKICK HIPPIEKICK requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Heleneabrahamsson @HIPPIEKICK