project-12-portfolio #396
Draft
project-12-portfolio #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
October 30, 2024 23:00
JennieDalgren
requested changes
Nov 11, 2024
|
Hopefully i managed to remove all node-files from the repository and updated the Netlify link. I didn't now what to put on the "article" section so I have the project there as well for now. |
HIPPIEKICK
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Changes requested
Have another look at your page in mobile (320px width):
- Your content doesn't fit
- Your profile image is oval
- The skills list's text is too small
In general, I'd like to ask you to go through all different widths to check how your page looks. Apart from this, double check spaces (margin, padding, gaps etc) and sizes (on fonts, images) and fonts (e.g. the buttons have Arial).
You've done a massive work fixing up old projects, so keep up the good work 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://erikamo-portfolio.netlify.app/