Week 12 - Frida/Alexander Labyrinth #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinSkill
reviewed
May 3, 2023
| justify-content: center; | ||
| align-items: center; | ||
| overflow: hidden; | ||
| pointer-events: none; |
There was a problem hiding this comment.
Great solution, to not be able to click again
Comment on lines
+30
to
+32
| <LoadingWrapper> | ||
| {isLoading && <Loading />} | ||
| </LoadingWrapper> |
There was a problem hiding this comment.
Could the loading wrapper styling be in the loading component and then conditionally render all at once?
| import React from 'react' | ||
| import { useSelector, useDispatch } from 'react-redux' | ||
| import game, { generateMoves } from 'reducers/game' | ||
| import styled, { keyframes } from 'styled-components/macro'; |
| export const GameBoard = () => { | ||
| const currentLocation = useSelector((store) => store.game.currentLocation) | ||
| const dispatch = useDispatch(); | ||
| // const isLoading = useSelector((store) => store.ui.isLoading) |
There was a problem hiding this comment.
If not intended to be used in production, this could be removed
| ); | ||
| })} | ||
| </OptionBox> | ||
| {currentLocation.coordinates === '1,3' && <div><WinnerText>Well done! You made it out alive!</WinnerText> <Button onClick={() => restartGame()}>Restart</Button></div>} |
There was a problem hiding this comment.
To show the end of game, you could also have rendered based on actions left. That way it would work even if the backend gets updated with additional coordinates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.