Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project labyrinth by Leo T. and Yu M. #201

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

khleoth
Copy link

@khleoth khleoth commented Apr 29, 2023

No description provided.

Copy link

@jenster5 jenster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the project I really like the theme and the animation. You have some problems with the CSS styling in different screens for example the second to last screen I cant read the entire text on the top and it would be nicer for the directions if you didnt need to scroll. But the functionality is working well and overall it is very well done. I also really like the design and popup message on the restart button that was a cool addition to the project.

@noraterbocs
Copy link

Nice theme, and nice job!
However, the styling needs some fixes, especially for the SingleActionWrapper component, where the height is not set by default so it keeps changing based on the text's size independently from the other SingleActionWrapper if there are 2 directions shown. Also since the width is not set either, that keeps changing depending on the text's size, as well. Regarding the CurrentRoomdescriptionText that it goes to the side when the screen width gets wider, is a good workaround, but I would solve it in a different way because like this they are partially overlapping each other when the screensize is between 1450 and 1466px.

…pper and made its own HTML tag with position absolute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants