Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alien Maze #194

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Alien Maze #194

wants to merge 36 commits into from

Conversation

IrupePozoGraviz
Copy link

No description provided.

@IrupePozoGraviz
Copy link
Author

Copy link

@sammyolsson sammyolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a cool project, we are very impressed!

The time and energy (and code) you spent on the animations really pays off, a-maze-ing.
The code is clean, well-organized and easy to follow. It's clear that you put a lot of thought into the user experience ⭐️.

/ Sammy, Hannah, Johanna

Comment on lines +20 to +22
<meta property="og:title" content="The Great Space Maze">
<meta property="og:description" content="Labyrinth Project by Irupé, Jonas and Vera">
<meta property="og:image" content="https://i.postimg.cc/0N2pYwWS/labyrinth.png">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job including OG-tags in this project!

letter-spacing: 2px;
font-weight: 900;
font-family: 'Bebas Neue', cursive;
cursor: pointer;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pointer already declared on row 15? Because that is the parent component I think. Maybe I am wrong.

@@ -0,0 +1,215 @@
/* eslint-disable no-nested-ternary */
// Rename component and whats the common use of lib?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is an internal comment.

@@ -0,0 +1,13 @@
import { createSlice } from '@reduxjs/toolkit'
/* Rename to load or loading or can we just use gameFetch.loading? */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this is an internal comment.

batch(() => {
dispatch(gameFetch.actions.setDescription(data.description));
dispatch(gameFetch.actions.setActions(data.actions));
dispatch(gameFetch.actions.setCoordinates(data.cordinates));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like coordinates are misspelled "cordinates" - but still works as intended?

import { Player } from '@lottiefiles/react-lottie-player';
import styled, { keyframes } from 'styled-components';

const flyRound = keyframes`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool use of keyframes, very nice!

<Game />
</Provider>
);
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really like the overall theme of your game - the images and colours, lotties and arrows looks so good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants