-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legacy Lock Final Project #90
base: main
Are you sure you want to change the base?
Conversation
- added capsuleDetails to the capsuleDetailPage
Combining code
…ty from CapsuleCard.
…tails Add CapsuleDetailsCard component to CapsuleDetailsPage
- added the gallerySwiper as a component
Feature dashboard image component
…ss and adjust it a bit.
…ad media and Create capsule button to fit inside the text area.
… CreateCapsule to the new component.
- fixed the responsiveness for mobile view by sizing the imgaes
Frontend: Fix the horrific images
Backend clean up
…y the button when open
- changed the z-factor of the create-button, so that the forms overla…
- fiexed the capsule page and images on dashboard
…buttons are visible
…round - added media for font-sizes, - added font-styles
Add styling to capsule-date to prevent default behavior on mobile.
- added font family to capsule detail page
- added @mobile for landing page to make sure that login and sign up …
- worked on the profile form: added media to make sure that image is …
Fix - Remove duplicate warning popup
Fix - Prevent default behavior for capsule-date on smaller screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Great job with this project. It is well structured and you ahve done a really good job both in frontend and backend.
I really like the idea too.
Design wise it feels like the landing page doesn't really match the actual product. maybe because of time constraints.
One idea - when you're adding a user that will receive this capsule, it would be nice to know if the user I put in is a valid user or not. I'm just guessing that it is for now.
One thing that you could improve is to make the css a bit more DRY. Right now the buttons, for example, does have more or less the same styling except for some parts. You can do ui components that has a base button layout and then just add tiny things on the things that differs. Or have some general sizes as variables or general classes. Depends on the approach you want to use. It is easy to forget strcturing the css when wokring on a big project like this.
I love all the features and functionality you have built!
So fun seeing this project and follow you progress during the bootcamp.
Really good job, you should be PROUD!
⭐
if (allowedMimeTypes.includes(file.mimetype)) { | ||
cb(null, true); | ||
} else { | ||
cb(new Error("Invalid file type. Only JPEG, PNG, GIF, MP4, WebM, and AVI are allowed.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error msg didnt really go through to frontend i believe.
When trying to add an image to a locket regarding this, i accidentally tried to upload a pdf but just got an alert with a fairly generic "Failed to upload"
router.delete("/delete-profile-image", authenticateUser, deleteProfileImage); | ||
|
||
router.put("/update-profile", authenticateUser, updateUserProfile); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with adding comments to explain these routes
@@ -0,0 +1,19 @@ | |||
import { useState, useEffect } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confetti! 🎉
<div className="clock-icon-latest"> | ||
<img className="clock-icon" src = "../../clock.png"alt="Clock icon"/> | ||
</div> | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation clean up
@@ -0,0 +1,61 @@ | |||
import { useState, useEffect } from "react"; | |||
import useStore from "../store/store"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
https://legacy-locket.netlify.app/
https://legacy-lock-2.onrender.com/
by:
Johanna Eriksson
GitHub: joheri1
Kelly Hunt
GitHub: jacquelinekellyhunt
Gitte Beckmann
GitHub: gittebe