Skip to content

Final project - Traktamente - Xing #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 95 commits into
base: main
Choose a base branch
from

Conversation

xingyin2024
Copy link

Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with this project!

Overall your code is structured in a very good and clear way. You have used proper commit messages throughout the projects, which is impressive since you have been working on this alone. You documentation is clear and structured.

You have worked extremly well with both your backend strcutre as well as you frontend. The design is lightweight and really good.

Really good job with the different form fields and how they automatically gets calculated when you out in different values.

Some tips for the future:
In the css structure: when building a larger project like this, set up the main rules like the font-sizes, margins, as variables as well as the colors and font families. Be more consistent with px or rem and try to keep you css more DRY. It is often that we forget about the css part, since we're focusing a lot on the functionality both in frontend and backend.

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants