Skip to content

Earth 2 PR #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

Earth 2 PR #15

wants to merge 69 commits into from

Conversation

@casalm26
Copy link

Team Earth 2 project - see description in readme. :)

casalm26 and others added 30 commits March 17, 2025 09:42
@casalm26
Initial commit
e3e1a21
@LindaSchonfeldt
Added js and ts files
5731fba
@LindaSchonfeldt
Merge branch 'main' of https://github.com/casalm26/js-project-weather…
cf8dc6f 
…-app
@casalm26
added images from figma
f2b6c5a
@casalm26
boilerplate
96fad3f
@casalm26
boilerple again since i missed a couple of things.
279c8dd
@casalm26
env file och api tillagt
6939ee6
@LindaSchonfeldt
added css file and changed the url for the cloud image in the html
afab28a
@casalm26
added .env and my API-key
1e0edf7
@casalm26
foundational elements added
43bcba9
@casalm26
added a dummy response from the api
6bb9125
@LindaSchonfeldt
Fixed the name of the js file in the html
7d69b92
@LindaSchonfeldt
Merge branch 'main' of https://github.com/casalm26/js-project-weather…
4490acc 
…-app
@casalm26
fixed file names...
a63c689
@casalm26
commit from mob session
79cd435
@casalm26
Second commit from mob session
3aa317f
@LindaSchonfeldt
Added an enum for weather states, funtionality for
c382b76 
checking weather states and displaying today'
weather
@LindaSchonfeldt
.
752b738
@casalm26
Caspian and Cathi fixing the fetch
eee5793
@casalm26
merge from Schoenfeldt
8dbdc15
@casalm26
commit from mob part 2
95fdf6a
@casalm26
missed a file
277556d
@casalm26
Mob-session no xyz
7011e2a
@LindaSchonfeldt
.
3c74ee7
@violacathrine
created new branch, new forecast function
920081e
@LindaSchonfeldt
Started on a geolocation function.
6407669
@HolaCarmensita
Render out info in divs weather-icon and weather-text. Not rendering …
a099e3f 
…the divs at the moment and also just using dummy_data
@violacathrine
test
04791ce
@LindaSchonfeldt
Start of geolocation functionality
b62c8c2
@LindaSchonfeldt
Updated the geolocation function
5746589
violacathrine and others added 25 commits March 19, 2025 13:46
@violacathrine
started with css
b2474ce
@casalm26
start of mob to get the app working
87b189d
@casalm26
commit because we forgot before
584bb99
@casalm26
got some elements to render now.
ec6489e
@casalm26
got all elementd to work
8a222ed
@casalm26
fixed weekdays names in English
f81b37d
@violacathrine
css fix
70b7235
@casalm26
merged styling and some css fixes
28bbdfb
@casalm26
got the text to render properly, and managed to style it
1154ca1
@casalm26
changed name of assets and minor fixes on html
3ebcc4a
@LindaSchonfeldt
added function to update body class
87ec691
@casalm26
fixed the icons rendering
8f00b2b
@casalm26
Merge remote-tracking branch 'origin/change-css' into dev-main
a0a7e63
@casalm26
merged css
d8bc751
@casalm26
Fix of icons and some weathers not rendering
4a035c2
@casalm26
Fixed icon and some css
6acae08
@casalm26
cleaned html
cee181e
@casalm26
cleaned html
8a91316
@casalm26
added readme
50a65bc
@casalm26
Fixed title of page
fa36748
@casalm26
Fixed title of page
0bfa0fb
@casalm26
minor fixes before demo
7718b48
@casalm26
Cleanup and refactoring - removed ca 200 lines of TS code.
8479851
@casalm26
Added readme and footer
bd22ff0
@casalm26
minor update to CSS
958f87d
JennieDalgren
JennieDalgren previously requested changes Mar 24, 2025
View reviewed changes
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bug about timezones:
Make sure that sunrise and sunset time makes sense.

image image

Fix this and then I can approve the project! 🚀

@casalm26
Copy link
Author

Hi @JennieDalgren — this should be fixed now. :)

HIPPIEKICK
HIPPIEKICK approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HIPPIEKICK HIPPIEKICK HIPPIEKICK approved these changes

@JennieDalgren JennieDalgren JennieDalgren left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@casalm26 @JennieDalgren @HIPPIEKICK @LindaSchonfeldt @violacathrine @HolaCarmensita