Weather App. Team: Darius, Therese, Tavan, Kasia, Jasmin #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther-app into searchbar-display-storage
JennieDalgren
requested changes
Mar 24, 2025
There was a problem hiding this comment.
Great job with this app!
You have some things to fix before getting approved on this project:
- Stick to one way of writing functions:
const name = () => {}orfunction name() {} - The icons doesnt seems to fit the weather? It cant be right that all cities have the same forecast?
- I can't see any conditional change of the design? Either day/night or based on weather?
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://teamweatherapp.netlify.app/