-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Project Recipe Library – Juan #16
base: main
Are you sure you want to change the base?
Conversation
…stments in css and html
…a different filter button
…utton, no functionality yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey i think it looks good you have fulfilled all requirements. I like that you add comments after functions it makes the code easy to read. You have a really fleshed out and dynamic page! You had a lot of interactive features for sorting and filtering! Good use of error handling too! I also like that you used async/await i did not think of that myself. If i had to nit pick i would say there is some repetition in logic.
sortByPopularity and sortByTime, which essentially perform the same task:
They copy the recipes array.
Sort it based on a specific property (e.g., popularity or readyInMinutes).
Return the sorted array. FYI i did the exactly that same thing so you know XD. Overall, this is a strong project with great attention to detail! Good job!!
…nr shows no recipes
… message defined in try blocks
Will continue to work on this one over the weekend, but it's fairly close to being finished!
The website is live at https://recipelib.netlify.app/