-
Notifications
You must be signed in to change notification settings - Fork 49
Alex: Portfolio #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Alex: Portfolio #29
Conversation
alex91-html
commented
May 4, 2025
- Netfly link: https://alex-codes-portfolio.netlify.app/
- figma link: https://www.figma.com/design/OrBxZbZNOs23n7gznIQGOX/Alex-U_Portfolio-design?node-id=1078-2177&m=dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice design, you’ve really made it your own! Only thing I can say design-wise is that it would look better if the ProjectCards were completely aligned (text part and image).
With that said: it’s responsive, you have a 96% score in Lighthouse (with this comment however: Lists do not contain only <li> elements and script supporting elements (<script> and <template>).) and your code is structured.
PS. Remember PascalCase for components and component files.
|
Thx u so much! Im going to bring those changes such a good point!
… On 13 May 2025, at 12:59, Matilda Brunemalm ***@***.***> wrote:
@HIPPIEKICK approved this pull request.
Nice design, you’ve really made it your own! Only thing I can say design-wise is that it would look better if the ProjectCards were completely aligned (text part and image).
With that said: it’s responsive, you have a 96% score in Lighthouse (with this comment however: Lists do not contain only <li> elements and script supporting elements (<script> and <template>).) and your code is structured.
PS. Remember PascalCase for components and component files.
—
Reply to this email directly, view it on GitHub <#29 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APARFUK7V4NAFIQFTNJT3A326HGAVAVCNFSM6AAAAAB4NMYEPOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZWGI3DGOJZGM>.
You are receiving this because you authored the thread.
|
MalLunBar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the design! Even though it's not exactly the one they gave us, but it's clear that it stems from design 2. Really love the font and the fade-in of the projects!
A few things that I realized along the way:
- When the page loads the Subtitle button is on. At that point there is no cursor or hover effect on the links, but when the Subtitle is off, there is. Maybe they should always have that?
- Like Matilda mentioned there is the text goes further down on the projects than the images.
- It is definitely responsive, but on mobile, the gap between some parts of the page are way bigger that others. Im specifically think about the bottom part with the Tech, Skills, Tools part. I now that Tech and Skills are the "Sections" and the Tools a kind of child of Skills, but Im thinking the the general viewer doesn't. One solution could be to make sure that the font size of Skills is a bit bigger than the Tools.
- One of the requirements is to have a picture of yourself :D Let everyone see your lovely face.
Overall I think this is a really cool portfolio and all of the things I mentioned are just tiny things that might make it even better! Great job!