Portfolio - Oscar L #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Want to implement testing, like Jest
…n't work. Might be some residue setting but all files should be removed
…ne, how to overwrite App.css?
…et view, with some kinks
…ng up in townhall
…orks through js states, false contrast errors?
Author
|
states added |
HIPPIEKICK
approved these changes
May 7, 2025
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
A11y
From Lighthouse: Uses ARIA roles on incompatible elements
Regarding the requirement: Your portfolio should follow the Figma design
- Really good job following the design Oscar! Only thing I can say is that you should double check the top/bottom padding of your sections - it should be 128px pretty consistently.
Codewise
- For folders that have more than one component in them - name them using camelCase.
- I don’t completely understand your structure, you have one folder called sections with a lot of component folders in it 🤔 And also some files directly in there (in no child folder).
- Remember to always default to const.
- Don’t forget the dependency array when working with useEffect!
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design: www.figma.com/board/PymjF0tI8PYjLJ45Ud1Ai9/Water-🌊?node-id=0-1&p=f&t=fyWZXSjCKeiorHlN-0 (in lower right corner)
Link: https://oscars-js-portfolio.netlify.app
My portfolio project. Followed, with tweaking, the second design. Most px are followed, with the exception when it doesn't function properly (ex featured/article link size). Styles is written in tailwind, with libraries for animation. Some styled components are used, to try it out. Data displayed through JSON. Vitest will be extended upon later, as well as adding js/using states. Includes og-tags
for PR: might have excessive components, didn't manage to make fewer, help appreciated.