-
Notifications
You must be signed in to change notification settings - Fork 50
Portfolio Project - Malin #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A11y
From Lighthouse: Heading elements are not in a sequentially-descending order
Regarding the requirement: Your portfolio should follow the Figma design
I’m really impressed. I have nothing to point out and that has honestly never happened before when it comes to the portfolio project 😅 Gold star to you Malin. OK, now I actually found a tiny thing - the font-size on desktop should be 18px according to the design (Skills section) but what a tiny thing compared to all the work you’ve put in. I think it looks great ⭐
Codewise
You have a very good structure of your project and you’ve used components and props in a good way. Your whole project is overviewable and clean. You’ve kept your entry point (App.jsx) clean which is good practice 👍 Nice that you used GlobalStyle!
SelinCoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 Design Review
When it comes to matching the Figma design — wow, I’m genuinely impressed. I didn’t spot anything at first glance😄 You've clearly paid attention to detail. Okay, I did eventually find a minor detail as mention earlier on desktop, the font size in the Skills section should be 18px to match the design. But honestly, that’s such a small note considering how much solid work you’ve done. It looks fantastic ✨
🔍 Code Review
From a code perspective, your structure is really solid. You’ve made smart use of components and props, which makes everything easy to follow. The project is well-organized and easy to read, and I appreciate how clean you’ve kept your App.jsx — that’s definitely good practice 👍 Also, great call using GlobalStyle to manage styling consistently. Well done Malin!
Please include a link to your Figma design and a Netlify link.
Netlify: https://malinlundgren.netlify.app/
Design: https://www.figma.com/design/dvCctNaRUTSADdwfFGvqgR/Malin---Figma-designs-for-students--Copy-?node-id=1078-906&p=f&m=dev
The portfolio contains all the sections it should with a small difference, that the My Words section, now is My Favourite Games. I didn't feel comfortable writing a lot of articles, but still wanted to use the design with the buttons, which meant I needed links somewhere. Right now you get to the trailers of the games I love.
Let me know If anything needs to be changed! :)