frida js-project-businness-site hand in #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 5, 2025 10:56
HIPPIEKICK
approved these changes
Sep 24, 2025
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Nice job with the business site! You’ve implemented CSS Grid and Flexbox in a good way; however, I’m not sure the Flexbox on the video element is doing anything 👀
Going forward - keep the JavaScript in a JavaScript file 😊
Comment on lines
+11
to
+14
| <link | ||
| rel="icon" | ||
| type="image" | ||
| href="logga2.png" |
Comment on lines
+172
to
+182
| <label | ||
| for="radio-button" | ||
| class="consent" | ||
| > | ||
| <input | ||
| type="radio" | ||
| id="radio-button" | ||
| name="consent" | ||
| > | ||
| I agree to the use of my information. | ||
| </label> |
Contributor
There was a problem hiding this comment.
This is not the most common input type when asking for acceptance. Radio buttons are used when the user should pick one of multiple options. When you only have one radio button it's impossible to "uncheck" it. I think you'd be better of with a checkbox in this case 😊
| no name kafé | ||
| </footer> | ||
|
|
||
| <!--java-for-hamburger--> |
Comment on lines
+200
to
+207
| <script> | ||
| const btn = document.querySelector('.hamburger'); | ||
| const links = document.querySelector('.nav-links'); | ||
|
|
||
| btn.addEventListener('click', () => { | ||
| links.classList.toggle('show'); | ||
| }); | ||
| </script> |
Contributor
There was a problem hiding this comment.
Keep the JavaScript in a separate JavaScript file going forward. It will be easier to maintain and find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to my Netlifly