Elvis – Business site #67
Conversation
Added Elvis Snus project submission
Added Elvis Snus project submission
Added Elvis Snus project submission
Add Project file (HTML, CSS, JS)
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Project Snus</title> | ||
| <link rel="stylesheet" href="style.css" /> |
There was a problem hiding this comment.
There are unnessesarry / in the code at several places
| class="form__control" | ||
| type="date" | ||
| name="deliveryDate" | ||
| id="deliveryDate" /> |
There was a problem hiding this comment.
The date selection is wonky, You can write up to 6 numbers in the year and you have 99 days to chose from if you write the date by hand.
| <option value="">Select...</option> | ||
| <option value="light">Light (2–4 mg)</option> | ||
| <option value="medium">Medium (6–8 mg)/option></option> | ||
| <option value="strong">Strong (10–14 mg)</option> | ||
| <option value="extra">Extra Strong (15mg+)/option></option> |
There was a problem hiding this comment.
There are a few dubble tags that needs to be removed
| <link rel="stylesheet" href="style.css" /> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css" /> |
There was a problem hiding this comment.
Is this second stylesheet active and what does it do?
carina90kaarli-png
left a comment
carina90kaarli-png
left a comment
There was a problem hiding this comment.
The code looks stuctured and clearly shows what it does
There was a problem hiding this comment.
whe i opened the console in the browser i saw an issue message that read: An element doesn’t have an autocomplete attribute.
| header.classList.remove("header--open"); | ||
| toggle.setAttribute("aria-expanded", "false"); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Over all the code looks good, clean and well organised.
| /* Hamburger menu*/ | ||
|
|
||
| /* Screen reader only text (hidden visually but accessible) */ | ||
| .sr-only { |
There was a problem hiding this comment.
I can not find any text in the html with this class. is it something you removed from the html but forgot in the css?
| /* === Mobile nav: hidden by default === */ | ||
| .header__nav { | ||
| display: none; | ||
| position: fixed; | ||
| top: 64px; /* push under header */ | ||
| left: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| background: #192939; | ||
| border-top: 1px solid rgba(255, 255, 255, 0.1); | ||
| padding: 1rem; |
There was a problem hiding this comment.
i would personaly shrink the width of the menu when it is open, it feels like you are clicking into another page with only 3 small words on it instead of a roll down menu
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job with your business site Elvis and am I allowed to say that I dig the topic 😉
Your form looks a bit weird on small phones (have a look at 320px width). It’s OK, but just so you're aware.
Good usage of CSS Grid and Flexbox! Maybe some margin to the sides in the nav would be nice 😇
3 participants
js-project-business-site
Elvis Snus Submission