Skip to content

Conversation

@carina90kaarli-png
Copy link

No description provided.

@HIPPIEKICK
Copy link
Contributor

Please share a link to your deployed site as well

@carina90kaarli-png
Copy link
Author

carina90kaarli-png commented Sep 22, 2025 via email

@HIPPIEKICK
Copy link
Contributor

I don't know what you mean with the About section, can't find any link 👀 You can share it as a comment when you open the PR, but you should also put it in your readme file for easy access 😊

@carina90kaarli-png
Copy link
Author

carina90kaarli-png commented Sep 23, 2025 via email

@HIPPIEKICK
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK closed this Sep 24, 2025
@HIPPIEKICK HIPPIEKICK reopened this Sep 24, 2025
@HIPPIEKICK
Copy link
Contributor

Just putting it here for transparency: https://crystal-mine.netlify.app/

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with your business site Carina! You've met all requirements but one: to use at least three different input types. You’ve chosen type text for your email input so if you just change that to email your good to go with that requirement.

Some other things to think about going forward:

  • Make sure all inputs have labels
  • Make sure you have the correct indentation. You can set up VSC to always use 2 spaces as an equivalent of tabbing.
  • Now that you know Flexbox, there’s no reason to use the outdated<br> tag 😉

Change request

  • Three different types of inputs

Apart from that - keep up the good work!




<form action="http://httpbin.org/anything" method="POST">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you use the https as the action, as it can otherwise result in browsers blocking the action

form.html Outdated
<br><br>
<p>Do you consent?</p>
<div class=""></div>
<input type= checkbox name="Yes" required> Yes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All attributes' values should have quotation marks around them (and no space). And remember to indent:

<input
  required
  type="checkbox"
  name="Yes"
/>
```

form.css Outdated
@@ -0,0 +1,45 @@
Label{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always lowercase

Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants