-
Notifications
You must be signed in to change notification settings - Fork 62
Carina's js project buisness site #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Please share a link to your deployed site as well |
|
I already put it in the ”about” section. Is that not visible to others? Where should i put it?Mvh Carina. ***@***.*** sep. 2025 kl. 09:02 skrev Matilda Brunemalm ***@***.***>:HIPPIEKICK left a comment (Technigo/js-project-business-site#64)
Please share a link to your deployed site as well
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I don't know what you mean with the About section, can't find any link 👀 You can share it as a comment when you open the PR, but you should also put it in your readme file for easy access 😊 |
|
Okej, i added the link in the readme and as a coment. But this is what i ment with the about
…________________________________
Från: Matilda Brunemalm ***@***.***>
Skickat: Tisdag, 23 september 2025 15:30
Till: Technigo/js-project-business-site ***@***.***>
Kopia: carina90kaarli-png ***@***.***>; Author ***@***.***>
Ämne: Re: [Technigo/js-project-business-site] Carina's js project buisness site (PR #64)
[https://avatars.githubusercontent.com/u/51529201?s=20&v=4]HIPPIEKICK left a comment (Technigo/js-project-business-site#64)<#64 (comment)>
I don't know what you mean with the About section, can't find any link 👀 You can share it as a comment when you open the PR, but you should also put it in your readme file for easy access 😊
—
Reply to this email directly, view it on GitHub<#64 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BVOJ5WB425REJ527LGXBRFT3UFDPRAVCNFSM6AAAAACG5RALI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMRUGAZTGNBTGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Tried to clarify here: |
|
Just putting it here for transparency: https://crystal-mine.netlify.app/ |
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with your business site Carina! You've met all requirements but one: to use at least three different input types. You’ve chosen type text for your email input so if you just change that to email your good to go with that requirement.
Some other things to think about going forward:
- Make sure all inputs have labels
- Make sure you have the correct indentation. You can set up VSC to always use 2 spaces as an equivalent of tabbing.
- Now that you know Flexbox, there’s no reason to use the outdated
<br>tag 😉
Change request
- Three different types of inputs
Apart from that - keep up the good work!
|
|
||
|
|
||
|
|
||
| <form action="http://httpbin.org/anything" method="POST"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you use the https as the action, as it can otherwise result in browsers blocking the action
form.html
Outdated
| <br><br> | ||
| <p>Do you consent?</p> | ||
| <div class=""></div> | ||
| <input type= checkbox name="Yes" required> Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All attributes' values should have quotation marks around them (and no space). And remember to indent:
<input
required
type="checkbox"
name="Yes"
/>
```
form.css
Outdated
| @@ -0,0 +1,45 @@ | |||
| Label{ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always lowercase
JennieDalgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
No description provided.