-
Notifications
You must be signed in to change notification settings - Fork 62
Qabalany - De-News #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
daniellauding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Not bad :) Just some recommendations for future work
README.md
Outdated
| CSS Grid structures the main layout; Flexbox aligns content within each card. | ||
|
|
||
| - **Hero Header** | ||
| A full-width hero section with a background image scales responsively across all viewports (320px–1600px). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice with the globe, and that i could spin. But it was a bit strange that my desktop cursor dissapeared on desktop :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
| - [x] Checkbox set | ||
| - [x] Select/dropdown | ||
| - [x] Submit button | ||
| - [x] Form configuration: POST method to `https://httpbin.org/anything` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i tried the form it didnt work for me, i landed on https://httpbin.org/anything

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.html
Outdated
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommended formatting:
- remove lines Leon - Business Site #70-71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? Because i think they dont need to be there, easier to scan and read :D
index.html
Outdated
| src="/images/ethereum2staking.jpg" | ||
| alt="Ethereum 2.0 Staking"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would use tab indent for those two lines
index.html
Outdated
| href="https://cryptopotato.com/ethereum-hitting-new-records-47-36-million-eth-stake-in-the-eth2-beacon-deposit-contract/?utm_source=chatgpt.com" | ||
| target="_blank" | ||
| rel="noopener noreferrer"> | ||
| read more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also would tab indent here :D
index.html
Outdated
| <input | ||
| type="checkbox" | ||
| name="topics" | ||
| value="ethereum" | ||
| class="checkbox-input"> | ||
| Ethereum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit off the formatting/indenting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style.css
Outdated
| /* Modern CSS reset to normalize default browser styles */ | ||
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| /* Remove default list styling */ | ||
| ul, ol { | ||
| list-style: none; | ||
| } | ||
|
|
||
| /* Remove default link styling */ | ||
| a { | ||
| text-decoration: none; | ||
| color: inherit; | ||
| } | ||
|
|
||
| /* Improve image handling */ | ||
| img { | ||
| max-width: 100%; | ||
| height: auto; | ||
| display: block; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great with some resetting! :)
style.css
Outdated
| /* =========================================== | ||
| CSS CUSTOM PROPERTIES (VARIABLES) | ||
| =========================================== */ | ||
|
|
||
| :root { | ||
|
|
||
| --bg-primary: #0d1117; /* Main dark background */ | ||
| --bg-secondary: #161b22; /* Secondary darker background */ | ||
| --bg-card: #21262d; /* Card background color */ | ||
| --neon-green: #2ea043; /* Primary neon accent */ | ||
| --neon-blue: #58a6ff; /* Secondary neon accent */ | ||
| --text-primary: #ffffff; /* Main text color */ | ||
| --text-secondary: #8b949e; /* Secondary text color */ | ||
| --text-muted: #6e7681; /* Muted text color */ | ||
|
|
||
| /* Typography */ | ||
| --font-tech: 'Orbitron', monospace; /* Futuristic font for headers */ | ||
| --font-body: 'Montserrat', sans-serif; /* Clean font for body text */ | ||
|
|
||
| /* Spacing system */ | ||
| --spacing-xs: 0.5rem; | ||
| --spacing-sm: 1rem; | ||
| --spacing-md: 1.5rem; | ||
| --spacing-lg: 2rem; | ||
| --spacing-xl: 3rem; | ||
|
|
||
| /* Border radius for consistent rounded corners */ | ||
| --border-radius: 8px; | ||
| --border-radius-lg: 12px; | ||
|
|
||
| /* Transition timing for smooth animations */ | ||
| --transition: all 0.3s ease; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables is good! A nice way to structure design tokens
style.css
Outdated
| /* ====================== | ||
| Styles for the contact form | ||
| ====================== */ | ||
| .contact-section { | ||
| padding: var(--spacing-lg) 0; | ||
| } | ||
|
|
||
| .contact-form { | ||
| max-width: 600px; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
| .form-group { | ||
| margin-bottom: var(--spacing-sm); | ||
| } | ||
|
|
||
| .form-label { | ||
| display: block; | ||
| margin-bottom: var(--spacing-xs); | ||
| color: var(--text-primary); | ||
| } | ||
|
|
||
| .form-input, | ||
| .form-textarea { | ||
| width: 100%; | ||
| padding: var(--spacing-xs); | ||
| border: 1px solid rgba(255, 255, 255, 0.1); | ||
| border-radius: var(--border-radius); | ||
| background-color: var(--bg-card); | ||
| color: var(--text-primary); | ||
| font-family: inherit; | ||
| } | ||
|
|
||
| /* Focus states for form elements */ | ||
| .form-input:focus, | ||
| .form-textarea:focus { | ||
| outline: none; | ||
| border-color: rgb(144, 236, 23); | ||
| box-shadow: 0 0 0 2px rgba(0, 255, 255, 0.2); /* Glow effect on focus */ | ||
| } | ||
|
|
||
| .form-textarea { | ||
| min-height: 150px; | ||
| resize: vertical; | ||
| } | ||
|
|
||
| .radio-group, | ||
| .checkbox-group { | ||
| margin-bottom: var(--spacing-xs); | ||
| } | ||
|
|
||
| .radio-label, | ||
| .checkbox-label { | ||
| display: flex; | ||
| align-items: center; | ||
| margin-bottom: var(--spacing-xs); | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .radio-input, | ||
| .checkbox-input { | ||
| margin-right: var(--spacing-xs); | ||
| accent-color: var(--neon-green); | ||
| } | ||
|
|
||
| .submit-btn { | ||
| background-color: var(--neon-blue); | ||
| color:var(--bg-primary); | ||
| border: none; | ||
| padding: var(--spacing-xs) var(--spacing-md); | ||
| border-radius: var(--border-radius); | ||
| font-weight: bold; | ||
| cursor: pointer; | ||
| transition: all 0.4s ease; | ||
| } | ||
|
|
||
| .submit-btn:hover { | ||
| background-color: var(--neon-green); | ||
| color: var(--text-primary); | ||
| background-color: var(--neon-green); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting a bit off from rest of css in the file, i would indent it more so it aligns with rest of the document
README.md
Outdated
| - [x] Form configuration: POST method to `https://httpbin.org/anything` | ||
| - [x] Responsive hamburger menu: | ||
| - [x] Visible on mobile devices | ||
| - [ ] Interactive functionality via DOM manipulation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure you had the time – but didnt see any Javascript file to open / close a hamburger menu, i can see you now used pure CSS for it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@daniellauding Wow, thanks for the incredibly detailed review! I really appreciate you going through everything so carefully, from the big stuff down to all the indentation. Those "Same" comments are gold for cleaning it all up. Thanks again for all your help! |
- Restored stable codebase to clean working state - Enhanced CSS: Fixed formatting, improved browser compatibility - Enhanced HTML: Added SEO optimization and accessibility features - Enhanced JavaScript: Modular architecture with error handling - Overall: Code cleanup, better maintainability, and improved UX
…tem, mobile nav improvements
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mohammad!
I was sure that I posted feedback to you a few weeks back, but now I see it's not there. So here goes ✨
This is quite advanced JavaScript for where we were in the course when you submitted this. You’ve explored some concepts we hadn’t fully covered yet, such as the this keyword, conditionals, objects, and try/catch blocks. Great that you want to explore new concepts!
With that said, it's important that you understand what’s going on in your code, especially if you’ve used AI. Do you feel confident explaining how each part works? If not, I recommend going through it step by step to make sure you fully grasp it.
Also - the code works well, but could it be made a bit easier to read or simplified in some places? Sometimes a bit of refactoring can help make complex code feel more approachable 😊
I'm approving this project, so my comments here are more of something to think about. I think you did a great job! Can you just make sure your Netlify link works so I can do a G/VG check on some visuals 😊
|
Hi Matilda! Thank you for the feedback! 😄 You’re absolutely right, the original solution you saw was more advanced than what we had covered at that point. I was eager to explore new concepts like this, objects, and try/catch, and spent my weekend diving in. I realized I had taken on more than I could handle at the time 😅. To make it fully understandable for myself, I simplified the code. I remember removing the try/catch statements during that process, which actually hinted that something was off with my previous code push. Earlier, I had restored an older push version of the project, creating a conflict that required a force push for subsequent updates. I didn’t realize this at first and only noticed the README update, so my final JS never made it to the remote. I’ve now force-pushed the simplified version. I really appreciate your guidance and suggestions about readability and refactoring, and I’ll keep them in mind as I continue practicing. My Netlify link has also been updated now. Thank you again for your support! 🙏 |
|
Thank you for sharing your reflection and process ⭐
|




De-News – Decode the Future of Decentralization
https://denews.fartist.live
denewswened.netlify.app
news portal focused on Web3, blockchain, and decentralized technology.
De-News – Decode the Future of Decentralization
This pull request includes the first version of the project, built with HTML and CSS only.
included:
Project folder structure
Semantic HTML layout with header, main, and footer
CSS styling for layout and design
Responsive design for different screen sizes
Basic accessibility (alt text, headings, contrast)
JavaScript features will be added in later versions.