Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added draft ApplyAttributesToInstances method #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxxsem
Copy link
Contributor

@maxxsem maxxsem commented Feb 3, 2023

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

18.9% 18.9% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #67 (894dcfa) into main (9c1c858) will decrease coverage by 1.96%.
The diff coverage is 21.15%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   74.43%   72.48%   -1.96%     
==========================================
  Files         145      146       +1     
  Lines        2766     2853      +87     
  Branches      251      259       +8     
==========================================
+ Hits         2059     2068       +9     
- Misses        707      785      +78     
Impacted Files Coverage Δ
....EAV.Service/Factories/AttributeInstanceFactory.cs 1.69% <1.69%> (ø)
CloudFabric.EAV.Service/EAVService.cs 83.62% <17.85%> (-3.80%) ⬇️
...in/Models/Attributes/TextAttributeConfiguration.cs 54.34% <66.66%> (ø)
...on/Attributes/TextAttributeConfigurationUpdated.cs 100.00% <100.00%> (ø)
...Fabric.EAV.Domain/Models/AttributeConfiguration.cs 60.80% <100.00%> (ø)
CloudFabric.EAV.Domain/Models/AttributeInstance.cs 100.00% <100.00%> (ø)
...Domain/Models/Attributes/ArrayAttributeInstance.cs 100.00% <100.00%> (ø)
....Domain/Models/Attributes/FileAttributeInstance.cs 100.00% <100.00%> (+25.00%) ⬆️
...Domain/Models/Attributes/ImageAttributeInstance.cs 100.00% <100.00%> (ø)
....Domain/Models/Attributes/TextAttributeInstance.cs 100.00% <100.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants