feature/OPS-82-FE-더치페이-생성-기능-구현 #13
Conversation
- 엑세스 토큰 만료 시 reissue가 호출 안되는 오류 수정 - refresh 토큰을 헤더로 주입하던 과정을 CookieJar로 수정 - usecase의 클래스들 기능 별로 패키지 분리 - 기타 utils 및 network 관련 파일들 core로 분리
There was a problem hiding this comment.
Pull Request Overview
This PR implements Dutch pay (group payment) creation functionality with significant architectural refactoring. The changes include fixing access token refresh issues by switching from header-based to CookieJar-based refresh token management, reorganizing usecase classes by feature packages, and moving core utilities and network components to dedicated core packages.
Key changes:
- Implemented Dutch pay creation feature with user selection, amount input, and payment request flow
- Fixed authentication token refresh mechanism by implementing CookieJar for automatic cookie management
- Reorganized codebase architecture by separating auth-related and Dutch pay-related domain entities and use cases
Reviewed Changes
Copilot reviewed 55 out of 56 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CreateDutchPayScreen.kt | New multi-step screen for creating Dutch pay requests with user selection and amount input |
| CreateDutchPayViewModel.kt | New ViewModel handling Dutch pay creation logic and state management |
| AuthInterceptor.kt | Updated token refresh logic to use CookieJar instead of manual cookie header management |
| UserRepository.kt | Refactored to focus only on user data retrieval, moved auth methods to AuthRepository |
| domain/entity/auth/* | Moved authentication-related entities to dedicated auth package |
| domain/entity/dutchpay/* | Added new entities for Dutch pay functionality |
| core/utils/Formatter.kt | New utility for currency formatting shared across components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Icon( | ||
| painter = painterResource(id = R.drawable.ic_launcher_foreground), | ||
| contentDescription = "remove", | ||
| tint = TiggleGrayText, | ||
| modifier = Modifier.size(12.dp) | ||
| ) |
There was a problem hiding this comment.
Using R.drawable.ic_launcher_foreground as a remove icon is incorrect. This should use a proper close/remove icon like Icons.Default.Close or a dedicated remove icon resource.
📄 요약 (Summary)
🔗 관련 이슈 (Related Issue)
✨ 주요 변경 사항 (Key Changes)
🙏 리뷰어에게 (To the Reviewer)