PlayerHolder refactor #11867
Merged
PlayerHolder refactor #11867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The player in playerHolder is exactly the player inside the `PlayerService`, which in turn is exactly passed through the IBinder interface. Thus we don’t have to pass both. Instead add `PlayerService.getPlayer()`. Also inline a few methods of `PlayerHolder` and simplify.
Only used once. Now the code looks weird … why is the service started twice??
Should make it easier to seperate the two further later, both of them are only implemented by VideoDetailFragment anyway, which is kind of a code smell!
Profpatsch
added
codequality
github-actions
bot
added
size/medium
ShareASmile
added
the
player
Isira-Seneviratne
approved these changes
Jan 25, 2025
Comment on lines
+223
to
230
| if (binder instanceof PlayerService.LocalBinder localBinder) { | ||
| final @Nullable PlayerService s = localBinder.getService(); | ||
| if (s == null) { | ||
| player = null; | ||
| } else { | ||
| player = s.getPlayer(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (binder instanceof PlayerService.LocalBinder localBinder) { | |
| final @Nullable PlayerService s = localBinder.getService(); | |
| if (s == null) { | |
| player = null; | |
| } else { | |
| player = s.getPlayer(); | |
| } | |
| } | |
| final var service = binder instanceof PlayerService.LocalBinder localBinder ? localBinder.getService() : null; | |
| player = service != null ? service.getPlayer() : null; |
There was a problem hiding this comment.
That’s a lot more complicated to read than without tertiaries!
Stypox
approved these changes
Jan 25, 2025
That … is kinda silly, but ok |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the PlayerHolder a bit.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence