Open
Conversation
There was a problem hiding this comment.
Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- index.html: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
src/pages/ScrapFlow.jsx:38
- [nitpick] Ensure that the 'fetchData' function is memoized or stable, as including it in the dependency array may trigger unnecessary re-renders if it changes on every render.
}, [currentPage, fetchData]);
src/pages/RecreationDetail.jsx:59
- The description concatenates an array with a string, which may not yield the intended format; consider joining the array using a separator (e.g., .join(', ')) before concatenation.
description={recreationData.purposeList.map((purpose) => PURPOSE[purpose].value) + recreationData.summary}
vite.config.ts
Outdated
There was a problem hiding this comment.
If multiple 'http:' occurrences may be present in the HTML, consider using a global flag (e.g., /http:/gi) to ensure all occurrences are replaced.
Suggested change
| .replace(/http:/i, 'https:') | |
| .replace(/http:/gi, 'https:') |
src/pages/RecreationDetail.jsx
Outdated
There was a problem hiding this comment.
The 'keywords' prop expects a string but an array is provided; consider joining the array into a comma-separated string using .join(', ') to meet the prop type requirements.
Suggested change
| keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value)} | |
| keywords={recreationData.keywordList.map((keyword) => KEYWORD[keyword].value).join(', ')} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 기능 설명
PageMetadata공통 컴포넌트 제작🔗 연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #155
🩷 Approve 하기 전 확인해주세요!
✅ 체크리스트