This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Boxop updates #95
Merged
Boxop updates #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
reviewed
Mar 20, 2024
dejabot
reviewed
Mar 21, 2024
|
nice job with this! I think it's close. main things:
thank you! |
|
I took a pass at creating a sample version of the restructured code so all climbing logic (incl overrides) happens within the climbing trigger, etc. this simplifies some of the context logic. I also merged main into this sample. See what you think. We can discuss tomorrow. |
dejabot
reviewed
Mar 22, 2024
* Sample Lights code (#96) * code etc * apply jay demon * Drive set rotation (#87) * added controlRobotOrientedWithRotationSetpoint * added comment * added rotation lock-on to drive * added controls in OI * turret shooter at home * removed old code from drive * used constant for threshold * added default speaker positions * spotless * clean up * changed controls and default * apply linter to streamline PR process * logs * fixed oi stuff * changed negative so that it tracks the red target correctly * made shootNow work with new changes * Allow shooting only for luis, seperate buttons for speaker vs amp, lint, some changes etc. * update conflicting buttons * new boxop code * removed unused PID controller * changed logic for shooting button without rotation lock * added VisionConstants and made visionSpeakerHelper update the robot position based on the known speaker position (rather than vice versa) * makes auton reset position based off of april tag if it sees * deleted wrong boxop climber code * added todo comment * removed unnecessary logging, added vision update to shootnow * theoretically fixed context issues * stopped drive once done using in shootNow, added timeouts * commented out spammy log * added shooting ability * added log to update * added extra pid value * added top * added scoring position, changed some constants * changed visionSpeakerHelper back to updating target position rather than robot position * minor shooter changes * Optimized turning so that it always goes in the shortest direction. * Ran spotlessApply * added drive rotation to be in run so it continues even after calling once everything works for the most part! * spotless * reverted untested drive change * added comment --------- Co-authored-by: Leek <[email protected]> Co-authored-by: Mixmix00 <[email protected]> Co-authored-by: ThatComposerDude <[email protected]> * Fix canid on candle (#97) * restructure climber controls so all climber stuff happens within an enable climber condition. this allows us to simplify the context ownership logic a little. * linting * merging latest from main * fix merge issues * bringing back closer to base pr (reducing diffs) --------- Co-authored-by: Mixmix00 <[email protected]> Co-authored-by: Rajit G <[email protected]> Co-authored-by: Leek <[email protected]> Co-authored-by: Mixmix00 <[email protected]> Co-authored-by: ThatComposerDude <[email protected]> Co-authored-by: Debajit Ghosh <[email protected]>
qntmcube
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added ability to override climber soft stops + buttons that must be pressed before climbing to prevent accidental climbing