This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
rewrite CANTalonFxMotorController to use Phoenix 6 APIs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for this PR, you only need to read the |
fc19fdc
to
9f862ce
Compare
rcahoon
reviewed
Feb 4, 2024
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/hal/wpilib/CANTalonFxMotorController.java
Outdated
Show resolved
Hide resolved
will discuss and only consider completing the plumbing if we think this is useful.
54b1129
to
f1a9ecf
Compare
Thx! PTAL? |
rcahoon
approved these changes
Feb 5, 2024
The-Arx
pushed a commit
that referenced
this pull request
Feb 10, 2024
* rewrite CANTalonFXMotorController to use Phoenix 6 APIs * addressing feedback from PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite MaroonFramework's
CANTalonFxMotorController
to use the Phoenix 6 APIs.The code supports most of
MotorController
's interface, though it currently does not support remote sensors, as the Phoenix 6 APIsCANcoder
s as remote sensorsCANcoder
's device ID, which the currentMotorController
APIs do not provideWe can extend the
MotorController
APIs to allow for this in a future PR.This code also makes
CANTalonFxMotorController
extendTalonFX
, rather than contain it. This allows for easier casting from aMotorController
(retrieved viaRobotProvider
) to aTalonFX
in case we want to use the lower-level APIs directly.NOTE: this branch is based on the branch that removes several API methods. Will rebase once that PR has been submitted.
How Has This Been Tested?
Tested basic functionality (eg,
set()
) on RevA.