Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix Drive.setCross() merge issue #23

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

dejabot
Copy link
Contributor

@dejabot dejabot commented Jan 28, 2024

Description

Drive.setCross() was not merged correctly during recent changes. The same module is incorrectly being steered during setCross(). This PR fixes the typos.

How Has This Been Tested?

Need to test on Gatorade.

  • Unit tests: [Add your description here]
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@dejabot dejabot requested a review from qntmcube January 28, 2024 17:01
Copy link
Contributor

@qntmcube qntmcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went over together, LGTM

@dejabot dejabot merged commit ca5e49d into main Jan 30, 2024
3 checks passed
@dejabot dejabot deleted the fix-drive-setcross-merge-issue branch January 30, 2024 20:33
The-Arx pushed a commit that referenced this pull request Feb 10, 2024
* fix typos from merge

* add comment

* fix setCross logic
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants