This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
update MaroonFramework to handle unspecified CAN bus values better #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
force-pushed
the
maroonframework-empty-canbus
branch
from
6a27825 to
0a9a2b8
Compare
rcahoon
approved these changes
Jan 30, 2024
The-Arx
pushed a commit
that referenced
this pull request
Feb 10, 2024
* pass empty string for can bus if not set in config * refactor common code into helper method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if a CANbus property is not specified (eg left as the default of
null), that can cause issues with CTRE code finding those devices. CTRE treats""as the default CAN bus. This change simply passes""for the CAN bus if not set.How Has This Been Tested?
Will test on SwerveAndShoot during the week.