Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Modularize mechanism reservation tracking #143

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

rcahoon
Copy link
Member

@rcahoon rcahoon commented Dec 9, 2024

Description

Refactor the code that tracks and asserts which Command has ownership of each Subsystem, so that it's more modular.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.

  • Unit tests: [Add your description here]
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@rcahoon rcahoon requested a review from dejabot December 9, 2024 17:31
@rcahoon rcahoon force-pushed the rcahoon/mf3-idle-requests branch from e7e6696 to b945597 Compare December 9, 2024 17:35
@rcahoon rcahoon force-pushed the rcahoon/mf3-reservation-modular branch from 97ff3d6 to eaa1efe Compare December 9, 2024 17:35
Copy link
Contributor

@dejabot dejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lg overall - mainly have some questions about intended usage and structure of the ReservingCommand wrapper and static methods.

@rcahoon rcahoon force-pushed the rcahoon/mf3-idle-requests branch from b945597 to 34a7f84 Compare December 13, 2024 05:24
@rcahoon rcahoon force-pushed the rcahoon/mf3-reservation-modular branch 2 times, most recently from e53b191 to cabc96f Compare December 13, 2024 06:09
@rcahoon rcahoon force-pushed the rcahoon/mf3-idle-requests branch from 34a7f84 to ab6b83a Compare December 14, 2024 09:59
@rcahoon rcahoon force-pushed the rcahoon/mf3-reservation-modular branch from cabc96f to 733a673 Compare December 14, 2024 10:02
Base automatically changed from rcahoon/mf3-idle-requests to mf3-dev December 14, 2024 10:04
@rcahoon rcahoon force-pushed the rcahoon/mf3-reservation-modular branch from 733a673 to 162e3f6 Compare December 14, 2024 10:05
@rcahoon rcahoon merged commit 984cc28 into mf3-dev Dec 14, 2024
2 checks passed
@rcahoon rcahoon deleted the rcahoon/mf3-reservation-modular branch December 14, 2024 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants