Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

merge AdvantageKit integration from MaroonFramework #12

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

dejabot
Copy link
Contributor

@dejabot dejabot commented Jan 16, 2024

Description

  • merge AdvantageKit integration from MaroonFramework
  • update AdvantageKit to latest version

How Has This Been Tested?

  • Unit tests: [Add your description here]
  • Simulator testing: tested in simulator
  • On-robot bench testing: tested on BurroBot in MaroonFramework and Gatorade in 2023.
  • On-robot field testing: [Add your description here]

This change is Reviewable

dejabot and others added 3 commits January 15, 2024 14:18
* basic installation and integration of AdvantageKit

* also log MF logs to WPI data logs

* brace yourself for lint checks

* log joystick input via DriverStation

* removing Logger line that looks like a bug.

* Fixed issue with logging on the simulator

* address PR comments

* fix merge conflicts

* change how we enable dual logging

* also dual-log for Logger.logRaw()

---------

Co-authored-by: ThatComposerDude <[email protected]>
also update to latest advantagekit
@dejabot dejabot requested a review from rcahoon January 16, 2024 03:11
@dejabot dejabot changed the title merge AdvantagKit integration from MaroonFramework merge AdvantageKit integration from MaroonFramework Jan 16, 2024
Copy link
Member

@rcahoon rcahoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - full merge

@dejabot dejabot merged commit 4e87915 into main Jan 16, 2024
3 checks passed
@dejabot dejabot deleted the merge-and-update-advantage-kit branch January 16, 2024 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants