Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Shooter assist #116

Merged
merged 29 commits into from
Apr 5, 2024
Merged

Shooter assist #116

merged 29 commits into from
Apr 5, 2024

Conversation

kentario
Copy link
Contributor

@kentario kentario commented Apr 4, 2024

Description

Added some minimal code in BoxOpOI that makes it so holding Y will move the shoulder and set the shooter speed to 4000 rpm if it is already spinning.

How Has This Been Tested?

This has not been tested besides building and spotlessApply.

@kentario kentario requested review from 1yd1a, qntmcube and dejabot April 4, 2024 01:48
Copy link
Contributor

@qntmcube qntmcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes you made look good
we could make use of the constant you made public for the default shooter speed, but this is not critical (we probably should have done this a long time ago)

Copy link
Contributor

@dejabot dejabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. nice, thanks!

Please don't merge yet, however. Let's merge this after better autons - and very ideally after we've gotten to test on the robot (eg in the pit).

@dejabot
Copy link
Contributor

dejabot commented Apr 4, 2024

merged latest from Better-Auton-Paths and then latest from main. PR diff should be easier to read now.

@qntmcube qntmcube merged commit 69da70a into main Apr 5, 2024
3 checks passed
qntmcube added a commit that referenced this pull request Apr 5, 2024
* driverOI handlePre

* changed autons to old shootNow

* adjusted auton path

* re-added DriverShootVelocityIntake in driverOI
changed auton to shoot off of subwoofer for first shot

* added timeout to auto intake and removed incorrect context ownership

* resets gyro to 180 degrees of current after auton is done

* stop shooter at the end of an auton and other context stuff

* Started making a more complete set of autons

* renamed autoIntake

* defualt 4800

* Shooter 4800 Changes and added center auton

* slight path tweaks

* spotless

* updated path

* Added midfield autons

* increased moveClimbersToBottom speed

* slightly decreased the intake feeding time into shooter for auton

* lowered climber speed back down, since it doesn't actually slow down the auton

* moved prox sensor threshold into a constant
we should increase to above 200

* Added minimal changes for shooter assist.

* Added some comments.

* reverted changes

* changed intake feeding time to 1.2 seconds

* Changed logic to rely on should run instead of target speed.

* commented log

* spotless

* Merge remote-tracking branch 'origin/Better-Auton-Paths' into Shooter-Assist

---------

Co-authored-by: qntmcube <[email protected]>
Co-authored-by: Leek <[email protected]>
Co-authored-by: Debajit Ghosh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants