This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejabot
reviewed
Mar 30, 2024
src/main/java/com/team766/robot/reva/procedures/DriverShootNow.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/robot/reva/procedures/DriverShootVelocityAndIntake.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/robot/reva/procedures/DriverShootVelocityAndIntake.java
Outdated
Show resolved
Hide resolved
src/main/java/com/team766/robot/reva/procedures/DriverShootVelocityAndIntake.java
Outdated
Show resolved
Hide resolved
1yd1a
reviewed
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good aside from one minor comment + don't forget spotlessApply
src/main/java/com/team766/robot/reva/procedures/DriverShootVelocityAndIntake.java
Outdated
Show resolved
Hide resolved
move alliance stuff into run re-add lost driver customizations
1yd1a
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split shootNow and shootVelocityAndIntake into multiple different procedures, one for auton and one for OI
Now boxop has complete control over shooting and intake only stops during a shot when driver releases button.
Added driver control customization that got lost when we copied over DriverOI
Removed unused (commented out) code
How Has This Been Tested?
Done a bunch of cycles on the carpet