Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Boxop shooter #111

Merged
merged 7 commits into from
Mar 30, 2024
Merged

Boxop shooter #111

merged 7 commits into from
Mar 30, 2024

Conversation

qntmcube
Copy link
Contributor

@qntmcube qntmcube commented Mar 30, 2024

Description

Split shootNow and shootVelocityAndIntake into multiple different procedures, one for auton and one for OI
Now boxop has complete control over shooting and intake only stops during a shot when driver releases button.
Added driver control customization that got lost when we copied over DriverOI
Removed unused (commented out) code

How Has This Been Tested?

Done a bunch of cycles on the carpet

  • Unit tests: [Add your description here]
  • Simulator testing: [Add your description here]
  • On-robot bench testing: [Add your description here]
  • On-robot field testing: [Add your description here]

@qntmcube qntmcube requested review from maxspier and dejabot March 30, 2024 03:19
@qntmcube qntmcube requested a review from 1yd1a March 30, 2024 16:52
Copy link
Contributor

@1yd1a 1yd1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good aside from one minor comment + don't forget spotlessApply

move alliance stuff into run
re-add lost driver customizations
Copy link
Contributor

@1yd1a 1yd1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@qntmcube qntmcube merged commit 3e6afee into main Mar 30, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants