log WPILogs to disk only #109

dejabot · 2024-03-26T04:59:46Z

Description

swap out WPI logging impl so this only logs to (USB) disk vs disk+console

tested on burrobot

Unit tests: [Add your description here]
Simulator testing: [Add your description here]
On-robot bench testing: tested on burrobot. found logs in WPI logs and viewed in AdvantageScope by dragging into console.
On-robot field testing: [Add your description here]

src/main/java/com/team766/logging/Logger.java

rcahoon · 2024-03-30T17:05:28Z

I notice there's a finish() method in DataLogEntry. Are we required to somehow call that, or is it optional?

rcahoon · 2024-03-30T17:08:08Z

Nvm, just read the docs. finish is optional

lgtm

dejabot requested a review from rcahoon March 26, 2024 04:59

dejabot commented Mar 26, 2024

View reviewed changes

src/main/java/com/team766/logging/Logger.java Show resolved Hide resolved

dejabot force-pushed the wpilog-onlylogtousb branch from 05723be to 886255c Compare March 30, 2024 05:27

rcahoon approved these changes Mar 30, 2024

View reviewed changes

log WPILogs to flash only, not console.

5ec1db8

dejabot force-pushed the wpilog-onlylogtousb branch from 886255c to 5ec1db8 Compare March 30, 2024 19:09

dejabot merged commit e14379e into main Mar 30, 2024
3 checks passed

dejabot deleted the wpilog-onlylogtousb branch March 30, 2024 19:28