This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
harden camera logic and update alliance logic (delay getting alliance until we'd expect it to be set) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and protect against other potential initialization errors
rcahoon
approved these changes
Mar 23, 2024
src/main/java/com/team766/robot/reva/mechanisms/ForwardApriltagCamera.java
Show resolved
Hide resolved
|
but wait, there's more |
dejabot
changed the title
|
Wait please don't merge yet -- I already updated the ForwardApriltagCamera mechanism to check for alliance color in run() and that code is in main (it looks VERY similar to yours). Please please check this before merging as it seems like your branch doesn't have these changes on it |
maxspier
suggested changes
Mar 23, 2024
src/main/java/com/team766/robot/reva/mechanisms/ForwardApriltagCamera.java
Outdated
Show resolved
Hide resolved
Changes merged, and discussed concerns with Max offline |
rcahoon
approved these changes
Mar 23, 2024
maxspier
added a commit
that referenced
this pull request
Mar 28, 2024
…off of main instead of fresno comp (also since this is the updated code) (#110) * changed paths * fixed absolute encoder * edit paths * Update AdvantageKit to match WPILib 3.2, and add fancy new AK version check * Fix mention of "uncaught" exceptions which might actually be caught * added a bunch of autons, needs testing * fix (#102) (#104) Co-authored-by: Lydia Honerkamp <[email protected]> * harden camera logic and update alliance logic (delay getting alliance until we'd expect it to be set) (#103) * harden camera/visionspeakerhelper code. delay when we get the alliance and protect against other potential initialization errors * update more alliance logic * set path to what path.flipPath() returns * address PR comments * Spotless fixes * Skip auton if can't determine flipping * linting --------- Co-authored-by: Ryan Cahoon <[email protected]> * exception * Tool to read log files off of the robot * logging, shoulder context, reverting swerve optimization * context improvement, shoot low tweaks * removed a bunch of logging * more logging * made shootVelocityAndIntake have less waits * commit code from ds laptop (max) * Add old shooting code back, add it in OI but no removal of other targeting code in OI (just no way to trigger it now) * code for reverting to old shooting code * lint all code * integrated with driver OI * apply linter to pass CL * add a stop drive * 54 point match! * Apply linter * removed intake takeOwnership in shootNow --------- Co-authored-by: qntmcube <[email protected]> Co-authored-by: Leek <[email protected]> Co-authored-by: Lydia Honerkamp <[email protected]> Co-authored-by: dejabot <[email protected]> Co-authored-by: Ryan Cahoon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
needs testing.