Test PR change - #9
Conversation
…staging to production PRs
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the GitHub Actions workflow to skip CI checks for staging-to-production pull requests by adding conditional logic and a dedicated skip job.
- Added conditional checks to prevent CI jobs from running on staging → production PRs
- Introduced a new job to explicitly handle and log the skipping of staging → production PRs
- Updated workflow triggers to ignore PRs targeting the production branch
| branches-ignore: | ||
| - production |
There was a problem hiding this comment.
The branches-ignore configuration conflicts with the conditional logic in jobs. Since you're adding if conditions to skip staging → production PRs, the branches-ignore: production will prevent the workflow from running at all for PRs targeting production, making the skip job unreachable.
| branches-ignore: | |
| - production |
|
|
||
| lint: | ||
| if: github.event.pull_request.base.ref != 'production' || github.event.pull_request.head.ref != 'staging' | ||
| types: [opened, synchronize, reopened, ready_for_review] |
There was a problem hiding this comment.
The types key is incorrectly placed inside the lint job definition. The types configuration should be under the pull_request trigger at the workflow level, not within individual jobs.
| types: [opened, synchronize, reopened, ready_for_review] |
| steps: | ||
| - run: echo "Skipping PR checks for staging -> production PR." | ||
| outputs: | ||
| skipped: true |
There was a problem hiding this comment.
The output value true should be quoted as 'true' in GitHub Actions. Unquoted boolean values may not be properly interpreted as strings when consumed by other jobs.
| skipped: true | |
| skipped: 'true' |
No description provided.