[FEAT] 질문 답변 조회 기능 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orijoon98
reviewed
Mar 5, 2024
Comment on lines
+21
to
+34
| @Id @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "answer_id") | ||
| var id: Long? = null, | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "member_id", nullable = false) | ||
| private var member: Member, | ||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "member_id", nullable = false) | ||
| var member: Member, | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "question_id", nullable = false) | ||
| private var question: Question, | ||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "question_id", nullable = false) | ||
| var question: Question, | ||
|
|
||
| @Column(name = "answer_content", nullable = false) | ||
| private var content: String, | ||
| @Column(name = "answer_content", nullable = false) | ||
| var content: String, |
There was a problem hiding this comment.
인텔리제이 기본 포매터+Tap size 4칸 으로 설정해주면 될 것 같아요!
Comment on lines
14
to
20
| @Transactional(readOnly = true) | ||
| fun findAnswerInfoById(id: Long): AnswerInfoResponse { | ||
| val answer = answerExplorer.findAnswerById(id) | ||
| val question = questionExplorer.findQuestionById(answer.getQuestionId()) | ||
|
|
||
| return AnswerInfoResponse.of(question, answer) | ||
| } |
There was a problem hiding this comment.
그 나만보기 설정한 답변 같은 경우에는 본인이 작성한 글인지 validation 과정이 필요할 것 같아요.
|
추가로 대환이형이 적용한 entity 에 _id 패턴이나, retriever, explorer 등 네이밍 컨벤션도 맞춰서 머지하면 좋을 것 같습니다. |
sookyungg
requested changes
Mar 6, 2024
Comment on lines
+21
to
+34
| @Id @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "answer_id") | ||
| var id: Long? = null, | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "member_id", nullable = false) | ||
| private var member: Member, | ||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "member_id", nullable = false) | ||
| var member: Member, | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "question_id", nullable = false) | ||
| private var question: Question, | ||
| @ManyToOne(fetch = FetchType.LAZY, cascade = [CascadeType.ALL]) | ||
| @JoinColumn(name = "question_id", nullable = false) | ||
| var question: Question, | ||
|
|
||
| @Column(name = "answer_content", nullable = false) | ||
| private var content: String, | ||
| @Column(name = "answer_content", nullable = false) | ||
| var content: String, |
There was a problem hiding this comment.
인텔리제이 기본 포매터+Tap size 4칸 으로 설정해주면 될 것 같아요!
| private val answerService: AnswerService | ||
| ) { | ||
| @Auth | ||
| @Operation(summary = "답변 조회") |
There was a problem hiding this comment.
명세서와 동일하게 [인증] 질문 답변 조회 로 바꿔주면 좋을 것 같습니다!
sookyungg
approved these changes
Mar 6, 2024
하나의 기능인데 지금 api가 많아져서 PR이 복잡하게 나눠졌네요 다 끝나고 수정하겠습니다..! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📸 Screenshot
📢 To Reviewers
LikeRepository에JpaRepository<Member, Repository>로 되어있는데, 이 부분을 바로 다음 PR에서 처리했습니다.이 부분에 대해서는 신경 안쓰셔도 될 것 같습니다!