Conversation
- actionButton에 leftIcon, rightIcon prop 추가 - Button 컴포넌트와 동일한 방식으로 아이콘 렌더링 - 아이콘 렌더링 테스트 4개 추가 (leftIcon, rightIcon, 동시 렌더링, onClick 통합) - 스토리북 예시 추가 (WithActionButtonLeftIcon, WithActionButtonRightIcon) - 버전 0.2.3 -> 0.2.4 - CHANGELOG.md 업데이트
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds optional Changes
Sequence Diagram(s)(omitted — changes are UI additions without a multi-component sequential control flow requiring visualization) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/components/modal/Modal.test.tsx`:
- Around line 529-608: The test fails because the Button implementation
short-circuits to render only leftIcon, but the Modal tests (actionButton prop
on Modal) expect both leftIcon and rightIcon to render; update the Button
component (Button / ButtonProps in src/components/button/Button.tsx) to accept
and render both leftIcon and rightIcon simultaneously (ensure props include
rightIcon if missing, and render leftIcon before the label and rightIcon after
the label instead of choosing one or the other), keeping existing onClick/aria
behavior; alternatively, if you prefer the API to allow only one icon, relax the
Modal test to assert only a single icon is supported (adjust tests referencing
Modal's actionButton leftIcon/rightIcon accordingly).
- Button 컴포넌트는 leftIcon과 rightIcon을 동시에 지원하지 않음 - leftIcon이 있으면 rightIcon은 무시되는 구조 - 동시 렌더링 테스트 케이스 제거 - 모든 테스트 통과 확인 (32 tests)
- 버전 0.2.4 -> 0.2.5 - CHANGELOG.md 업데이트 - Fixed 섹션에 테스트 케이스 제거 내용 추가 - Button 컴포넌트의 leftIcon/rightIcon 동작 설명 추가
- package.json: 버전 0.2.5 유지 - CHANGELOG.md: 0.2.5와 0.2.4 항목 모두 유지 - src/styles/utilities/typography.css: text-body-2-b 클래스 이미 포함됨
📝 Summary
Modal 컴포넌트의 actionButton에 leftIcon, rightIcon 지원 추가
🎯 Changes
Added
leftIcon: 버튼 왼쪽에 표시할 아이콘rightIcon: 버튼 오른쪽에 표시할 아이콘Interface Changes
사용 예시
✅ Checklist
📦 Version
0.2.3 → 0.2.4
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.