refactor(thumbsup): thumbsup 도메인 리팩토링 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qlido
previously approved these changes
Apr 30, 2024
| private final QueryAuthService queryAuthService; | ||
|
|
||
| @LoginRequired | ||
| @PostMapping("/create") |
There was a problem hiding this comment.
create를 지우는 편이 더 restful한거 같습니다!!
| .toList(); | ||
| } | ||
|
|
||
| @GetMapping("/{title}") |
There was a problem hiding this comment.
docs에 관련된 조회 api에서 docsId와 docsTitle 2가지를 사용하는데 통일 하는건 어떨까요?
There was a problem hiding this comment.
통일감을 주는 건 좋을 것 같아요! 그러나 이 부분은 제가 생각이 조금 다른게,
- 글 제목이 api의 path에 스트링이 오는 것보단, 숫자가 오는게 에러 확률이 더 적고,
- 조회에서 더 빠르고,
- 이미 프론트 백엔드 코드가 완성이 되어있기 때문에
유지하는게 더 좋은 것 같습니다!! 어떻게 생각하시나요?
|
아 @nested 했을 때 ascii only규칙이 적용되어서 checkstyle에러뜨네여;; |
hw9402
reviewed
Apr 30, 2024
Comment on lines
7
to
9
| public DocsThumbsUpResponseDto(Long thumbsUpsCount) { | ||
| public ThumbsUpCountResponseDto(Long thumbsUpsCount) { | ||
| this.thumbsUpsCount = thumbsUpsCount; | ||
| } |
There was a problem hiding this comment.
아니요! class에서 record로 전환하면서 생긴 코드인 것 같습니다. 지우겠습니다!
NameIsUser06
previously approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.