Conversation
[Release]: HOTFIX - 우물 아이템 추가 모션 오류 수정
[Release]: 상점 이동 기능, 단점 태그 optional로 변경 등
[Release]: 유저 플로우 개선, Navigation Bar 고정 등
[Release]: safari z-index 이슈 해결
[Release]: 피드 skeleton 버그 수정
[Release]: 우물 탐색/검색 기능 추가 및 기타 리팩토링
[Release]: NavBar 상태관리 버그 수정 및 기타 작업
[HOTFIX]: profile redirect 버그 수정
# Conflicts: # public/sw.js # public/sw.js.map # src/features/Well/components/Well/WellDetailPage.tsx # src/features/Well/components/Well/WellItem/WellItem.tsx # src/features/Well/components/Well/WellItem/WellItemList.tsx # src/features/Well/hooks/useWellItems.ts
# Conflicts: # package-lock.json # public/icons/index.ts # public/sw.js # public/sw.js.map # src/data/ui/bottomSheet.tsx # src/features/Well/api/well.api.ts # src/features/Well/components/Well/WellDetailPage.tsx # src/features/Well/components/Well/WellFrog/FrogOnBook.tsx # src/features/Well/components/Well/WellHeader/WellHeader.tsx # src/features/Well/components/Well/WellItem/WellItemList.tsx
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SebellKo
approved these changes
Aug 5, 2025
| "next-auth": "^4.24.7", | ||
| "next-pwa": "^5.6.0", | ||
| "react": "^18.3.1", | ||
| "react-beautiful-dnd": "^13.1.1", |
Contributor
There was a problem hiding this comment.
이 패키지 이제 deprecated됐을텐데 괜찮아요 ?
atlassian/react-beautiful-dnd#2672
Contributor
Author
There was a problem hiding this comment.
당장 react 19버전으로 업그레이드 할 예정은 없으니 기타 의존성 문제 생길 때 마이그레이션 하면 된다고 생각합니다~
| order: newOrder, | ||
| }); | ||
|
|
||
| console.log(prevChanges); |
| await updateWellItemOrder({ | ||
| well_id: wellData.id, | ||
| changes: orderChanges, | ||
| }); |
Contributor
There was a problem hiding this comment.
이건 왜 mutation안쓰시고 바로 호출하셨어요 ?
| isFetched: boolean; | ||
| setTarget: React.Dispatch< | ||
| React.SetStateAction<HTMLDivElement | null | undefined> | ||
| >; |
Contributor
There was a problem hiding this comment.
이거 상위 컴포넌트에서 상태업데이트 함수 직접 내려주지 말고 별도 함수 선언해서 내려주는게 개인적으로 더 취향이긴 한데 어떻게 생각하세요 ?
const handleSetTarget = () => setTarget()
Contributor
Author
There was a problem hiding this comment.
저도 그게 더 좋아요
이건 짤때 조급하게 짰달까..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍 작업 내용
📍 구현 결과 (선택)
📍 기타 사항
리뷰어가 특별히 봐주었으면 하는 부분이나 주의사항, 알림사항 등이 있다면 작성해주세요.
ex) 더미 데이터를 넣어서 기능 구현한 상태입니다!