Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SebellKo
commented
Aug 4, 2025
| /** 도서 상세 페이지, 리뷰/메모 리스트 내 도서 정보 컴포넌트 (도서 커버, 배경 포함) */ | ||
| function BookInfo({ bookId, bookData, canClick = false }: Props) { | ||
| const isInFeed = useIsInFeed(); | ||
| const isEmpty = !bookData.title; |
Contributor
Author
There was a problem hiding this comment.
author가 unknown으로 렌더링 되는 경우도 있어서 title이 없는 경우를 empty 상태로 판단했습니다.
SebellKo
commented
Aug 4, 2025
|
|
||
| if (!bookData) return null; | ||
|
|
||
| const fallbackCategory = 'cartoon'; |
Contributor
Author
There was a problem hiding this comment.
디자인 시안상 fallback ui 색상이 cartoon이라 이걸로 적용했습니다.
SebellKo
commented
Aug 4, 2025
| const height = page > 400 ? page * 0.15 : 55; | ||
| const isReading = status === 'reading'; | ||
| const hasMemo = memo_cnt > 0; | ||
| const fallbackCategory = 'economic_business'; |
Contributor
Author
There was a problem hiding this comment.
여기도 마찬가지로 디자인 시안상 fallback ui 카테고리가 이거여서 이걸로 설정했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍 작업 내용
📍 구현 결과 (선택)
📍 기타 사항
리뷰어가 특별히 봐주었으면 하는 부분이나 주의사항, 알림사항 등이 있다면 작성해주세요.
ex) 더미 데이터를 넣어서 기능 구현한 상태입니다!