-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create-new-profile.sh #15
Conversation
will probably need some double checks first |
create-new-profile.sh
Outdated
# Validate resolution format | ||
if ! [[ "$RESOLUTION" =~ ^[0-9]+x[0-9]+$ ]]; then | ||
error_exit "Invalid resolution format for player $(($i + 1)). Use format: 1280x720" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fi
, not }
create-new-profile.sh
Outdated
# Validate resolution format | ||
if ! [[ "$RESOLUTION" =~ ^[0-9]+x[0-9]+$ ]]; then | ||
error_exit "Invalid resolution format. Use format: 1280x720" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another stray bracket here
Seems like a useful feature; especially for those like myself, not sure how to adjust the GAMERUN variable for proton games. The script seems a little first draft-y. Couldn't get it running at first, due to some issues with the kdialog prompts that I didn't have on the original script. Likely just an issue with my local steamos install, so I removed the added checks, and forced the use of zenity instead (though the original script runs fine with kdialog). Fixing the aforementioned minor typos, and the script works as expected. |
address comments
dont worry, im a complete noob at all this. so the first draft-y look doesnt supprise me. worst case, it isnt directly implemented but is used as a foundation/better version that does the same thing. |
added proton to profile creation