Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-new-profile.sh #15

Closed
wants to merge 7 commits into from
Closed

Conversation

DrLegitamate
Copy link

added proton to profile creation

@DrLegitamate
Copy link
Author

will probably need some double checks first

# Validate resolution format
if ! [[ "$RESOLUTION" =~ ^[0-9]+x[0-9]+$ ]]; then
error_exit "Invalid resolution format for player $(($i + 1)). Use format: 1280x720"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fi, not }

# Validate resolution format
if ! [[ "$RESOLUTION" =~ ^[0-9]+x[0-9]+$ ]]; then
error_exit "Invalid resolution format. Use format: 1280x720"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another stray bracket here

@Nuddel69
Copy link

Nuddel69 commented Dec 5, 2024

Seems like a useful feature; especially for those like myself, not sure how to adjust the GAMERUN variable for proton games. The script seems a little first draft-y. Couldn't get it running at first, due to some issues with the kdialog prompts that I didn't have on the original script. Likely just an issue with my local steamos install, so I removed the added checks, and forced the use of zenity instead (though the original script runs fine with kdialog). Fixing the aforementioned minor typos, and the script works as expected.

@DrLegitamate
Copy link
Author

Seems like a useful feature; especially for those like myself, not sure how to adjust the GAMERUN variable for proton games. The script seems a little first draft-y. Couldn't get it running at first, due to some issues with the kdialog prompts that I didn't have on the original script. Likely just an issue with my local steamos install, so I removed the added checks, and forced the use of zenity instead (though the original script runs fine with kdialog). Fixing the aforementioned minor typos, and the script works as expected.

dont worry, im a complete noob at all this. so the first draft-y look doesnt supprise me. worst case, it isnt directly implemented but is used as a foundation/better version that does the same thing.

@DrLegitamate DrLegitamate closed this by deleting the head repository Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants