Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: starting to test filter types #5849

Draft
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

tylersayshi
Copy link

No description provided.

@@ -42,6 +43,8 @@ const _features = tableFeatures({
rowPaginationFeature,
})

type TestType = ExtractFeatureTypes<typeof _features, 'Column'>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently unknown. It seems like more needs to be done to override the interface of the Columns maybe, is this correct?

@KevinVandy
Copy link
Member

Where would attest be installed?

@KevinVandy
Copy link
Member

maybe another branch that actually uses the ExtractFeatureTypes should be made? We'll uncomment that code in that branch, run attest on both the alpha branch and that one.

@tylersayshi
Copy link
Author

Where would attest be installed?

Probably the root package.json devDeps. This way we can test examples, packages/* and anything else from there.

I don't have any strong opinion on this though. I did a global install of it locally and I am just sampling as I cd around the repo right now.

@tylersayshi
Copy link
Author

maybe another branch that actually uses the ExtractFeatureTypes should be made? We'll uncomment that code in that branch, run attest on both the alpha branch and that one.

yeah, this would be really helpful. Is it just a matter of uncommenting all the commented out types?

I was unsure if not all of them were commented for the same reasons or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants