Skip to content

feat: allow use of nitro zero conf #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Apr 14, 2025

Ref: https://nitro.build/deploy#zero-config-providers

Nitro will automatically fallback to node-server if it doesn't recognize environment of one of supported zero configuration deploy targets https://nitro.build/deploy#default-output.

Note nksaraf/vinxi#325 was similar change done some time ago in Vinxi to allow for zero-configuration

Copy link

nx-cloud bot commented Apr 14, 2025

View your CI Pipeline Execution ↗ for commit 6b7c912.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 14m 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 18:48:46 UTC

Copy link

pkg-pr-new bot commented Apr 14, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@3993

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@3993

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@3993

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@3993

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@3993

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@3993

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@3993

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@3993

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@3993

@tanstack/react-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-config@3993

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@3993

@tanstack/react-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-router-manifest@3993

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@3993

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@3993

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@3993

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@3993

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@3993

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@3993

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@3993

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@3993

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@3993

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@3993

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@3993

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@3993

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@3993

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@3993

@tanstack/solid-start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-config@3993

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@3993

@tanstack/solid-start-router-manifest

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-router-manifest@3993

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@3993

@tanstack/start

npm i https://pkg.pr.new/TanStack/router/@tanstack/start@3993

@tanstack/start-api-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-api-routes@3993

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@3993

@tanstack/start-config

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-config@3993

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@3993

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@3993

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@3993

@tanstack/start-server-functions-handler

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-handler@3993

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@3993

@tanstack/start-server-functions-ssr

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-ssr@3993

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@3993

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@3993

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@3993

commit: 6b7c912

Copy link
Contributor

@zrosenbauer zrosenbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is native, LGTM... just make sure the tests pass and then I can approve.

@pieh
Copy link
Contributor Author

pieh commented Apr 24, 2025

@zrosenbauer I couldn't see actual test failing in last run. Those tests also did pass locally for me.

CI pipeline execution 14452307481-3 cancelled. Reason: One or more workflows failed.

Cloud test runner seemed to crash because of

One or more agents restarted due to out of memory errors
If the issue persists, consider trying a larger resource class.
( https://cloud.nx.app/cipes/67fd536af0399328e141fe26 ) which is likely source for overall failure?

As I'm not that familiar with CI here, I'm not sure if this is potentially recurring problem happening from time to time due to overall test setup or if it's actually caused by this change ( but this would be pretty unexpected to me, unless somehow Nitro's platform detection is very memory hungry)

@zrosenbauer
Copy link
Contributor

@zrosenbauer I couldn't see actual test failing in last run. Those tests also did pass locally for me.

CI pipeline execution 14452307481-3 cancelled. Reason: One or more workflows failed.

Cloud test runner seemed to crash because of

One or more agents restarted due to out of memory errors
If the issue persists, consider trying a larger resource class.
( https://cloud.nx.app/cipes/67fd536af0399328e141fe26 ) which is likely source for overall failure?

As I'm not that familiar with CI here, I'm not sure if this is potentially recurring problem happening from time to time due to overall test setup or if it's actually caused by this change ( but this would be pretty unexpected to me, unless somehow Nitro's platform detection is very memory hungry)

Yea most likely just get those approved and were good

Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@schiller-manuel schiller-manuel force-pushed the feat/allow-nitro-zero-conf branch from c1ce053 to 6b7c912 Compare April 25, 2025 16:46
@schiller-manuel schiller-manuel merged commit 8edeeaa into TanStack:main Apr 25, 2025
8 of 11 checks passed
schiller-manuel added a commit that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants