Skip to content

feat(vue-query): useInfiniteQuery options support maybe ref type #8956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

feat(vue-query): useInfiniteQuery options support maybe ref type #8956

merged 3 commits into from
Apr 10, 2025

Conversation

aa900031
Copy link
Contributor

@aa900031 aa900031 commented Apr 4, 2025

The useInfiniteQuery can directly use Ref in the runtime, but it's not supported at the Type level.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 4, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6977598.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 11s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-10 14:32:52 UTC

@aa900031 aa900031 changed the title feat: useInfiniteQuery options support maybe ref type feat(vue-query): useInfiniteQuery options support maybe ref type Apr 4, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 4, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8956

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8956

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8956

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8956

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8956

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8956

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8956

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8956

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8956

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8956

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8956

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8956

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8956

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8956

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8956

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8956

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8956

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8956

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8956

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8956

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8956

commit: 6977598

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.01%. Comparing base (d2768d3) to head (6977598).
Report is 26 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8956       +/-   ##
===========================================
+ Coverage   44.09%   71.01%   +26.91%     
===========================================
  Files         201       19      -182     
  Lines        8025      483     -7542     
  Branches     1762      136     -1626     
===========================================
- Hits         3539      343     -3196     
+ Misses       4058      110     -3948     
+ Partials      428       30      -398
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query 71.01% <100.00%> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aa900031
Copy link
Contributor Author

aa900031 commented Apr 6, 2025

@DamianOsipiuk Please review this, thank you

DamianOsipiuk
DamianOsipiuk reviewed Apr 10, 2025
View reviewed changes
packages/vue-query/src/useBaseQuery.ts Outdated
@@ -49,7 +49,7 @@ type UseQueryOptionsGeneric<
TQueryFnData,
TError,
TData,
TQueryData,
TQueryFnData,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a proper change. Why this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! that's my fault, I'm already fix it

@DamianOsipiuk DamianOsipiuk merged commit f56a9f2 into TanStack:main Apr 10, 2025
7 checks passed
@aa900031 aa900031 deleted the feat/vue-infinite-query-support-mabe-ref branch April 10, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianOsipiuk DamianOsipiuk DamianOsipiuk left review comments

Assignees
No one assigned
Labels
package: vue-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aa900031 @DamianOsipiuk