-
-
Notifications
You must be signed in to change notification settings - Fork 525
fix(form-core): Fix array fields being stale on array change #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 97a9877
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
+ Coverage 90.35% 90.59% +0.24%
==========================================
Files 38 38
Lines 1752 1787 +35
Branches 444 446 +2
==========================================
+ Hits 1583 1619 +36
Misses 149 149
+ Partials 20 19 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Notes to self: Swapping, deletion and basic reset seems to work. However, there's conflicts with the reset that need further investigating. |
…stack-form into undefined-default-value
|
…efined-default-value
|
93e3caa
to
60e4c68
Compare
Todos:
|
FieldApi.update
Solid appears to be struggling with this implementation still. I'll look into what can be done to fix it. |
Closes #1614
Closes #1561
Closes #1577 , though it's not clear if it unintentionally broke something else solid-form-related.
Affects #1289 , though I have not confirmed that it fixes
deleteField
yet. Feedback from author is appreciatedMight close #1638 , feedback from author is needed
Fixes:
field.handleChange(undefined)
no longer sets the value to the default valueform.reset()
and array methods no longer break controlled input when non-index keys are usedTodos: