-
-
Notifications
You must be signed in to change notification settings - Fork 544
feat: add useAppForm API to Vue #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit e2648fb
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1455 +/- ##
==========================================
- Coverage 88.83% 82.89% -5.94%
==========================================
Files 31 3 -28
Lines 1379 76 -1303
Branches 347 3 -344
==========================================
- Hits 1225 63 -1162
+ Misses 137 12 -125
+ Partials 17 1 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, I was just looking for a way to split a form in Vue (using TanStack Form) into separate fieldset components (using useAppForm). Have you by any chance already found a way to pass the form context to a fieldset component in Vue? Or maybe a way to work with just a subset of the main form? Specifically, I was trying to create a reusable fieldset for an address, so I could easily reuse it across different forms. |
|
Unfortunately we're blocked by this ATM on Vue's side: |
|
Even though it's not ideal with Vue, it might make sense to use the workaround for now — and once the Vue issue is resolved, we wouldn't need the workaround anymore. I just tested it again with your StackBlitz example, and as soon as I write |
|
No dice; Since we're in v1, introducing an API on our end requires docs, migration patterns, and more. I've considered allowing for The workaround for now - if you'd like to do that yourself until we launch - is to copy+paste the implementation of |
|
@crutchcorn However, Vue is really missing the form composition feature. I know vuejs/core#8553 blocks this, but I agree with @daniel100097 here - I think it makes sense to release it with the current limitation that requires using IMO, a limitation on the Vue side shouldn't block this feature, as this workaround is a reality of working with the Vue framework. Once the issue is resolved (or not, cause in vue you have to do the same trick for other situations, like when you use a component in computed, etc), existing code using P.S. I found that even Vue Router uses P.P.S. Also, I found that |
TODOs: