Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meta should not regenerate every render #1114

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

crutchcorn
Copy link
Member

Closes #1108

Copy link

nx-cloud bot commented Jan 15, 2025

View your CI Pipeline Execution ↗ for commit 94e6cd7.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 49s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 01:36:03 UTC

Copy link

pkg-pr-new bot commented Jan 15, 2025

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1114

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1114

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1114

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1114

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1114

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1114

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1114

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1114

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1114

commit: 94e6cd7

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (b60264c) to head (94e6cd7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   86.61%   86.70%   +0.09%     
==========================================
  Files          29       29              
  Lines        1173     1181       +8     
  Branches      288      295       +7     
==========================================
+ Hits         1016     1024       +8     
  Misses        144      144              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 08d610f into main Jan 15, 2025
7 checks passed
@crutchcorn crutchcorn deleted the fix-meta-regeneration branch January 15, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Every <form.Field> rerenders when any field changes due to @tanstack/react-store shallow comparison of meta
1 participant