feat: centralize config management with validation and defaults#130
Open
Jayking40 wants to merge 1 commit intoTalenttrust:mainfrom
Open
feat: centralize config management with validation and defaults#130Jayking40 wants to merge 1 commit intoTalenttrust:mainfrom
Jayking40 wants to merge 1 commit intoTalenttrust:mainfrom
Conversation
|
@Jayking40 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Config Management Refactor
Summary
This PR implements a centralized configuration management system for the TalentTrust Backend. Previously, environment variables were read directly via
process.envscattered across the codebase with no validation or type safety. This refactor consolidates all config parsing into a single typed module that validates required variables at startup, applies safe defaults, and fails fast with a clear error message if the environment is misconfigured.This improves security (no silent misconfigurations), developer experience (one place to find all config), and maintainability (typed config object instead of raw string reads).
Changes
New Configuration Module
src/config/env.ts — Low-level environment variable parsing utilities with comprehensive validation:
src/config/index.ts — Centralized configuration with typed interfaces:
config— Frozen singleton loaded once at startupStartup Validation
All environment variables are validated at boot time:
Refactored Entry Point
process.env.PORTusage withconfig.server.portfrom the centralized config moduleComprehensive Test Coverage
Documentation
Development Tooling
npm run lintto fail)Testing
npm run build— Clean TypeScript compilation with zero errorsnpm test— 44 tests passed (2 suites)npm run lint— Zero linting errorsnpx tsc --noEmit— Zero type errorsMigration Notes
No breaking changes. The existing
PORTenvironment variable continues to work exactly as before, now with added validation. New optional variables have safe defaults and do not require immediate configuration.Closes #72