Fix: currentPage becomes -1 when the list is empty #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomagladiator
approved these changes
Jun 22, 2018
|
Tested, works ! |
|
Tested! and Works Perfectly. Please Merge it as soon as possible to save some trouble for others. |
|
I've beed struggling with this bug for the entire day :/ Can anyone for the god sake merge this please? 😭 |
|
@TahaSh - Please can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this solution is a little better than the one proposed in #95 since this fixes the problem at the source (but either will work!). Also added a test for it.
Fixes #94